ric/MailHog
1
0
Fork 0
mirror of https://gitlab.com/ric_harvey/MailHog.git synced 2024-11-23 22:34:04 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Add AUTH PLAIN tests

Browse source
This commit is contained in:
Ian Kent 2014-11-23 13:27:35 +00:00
parent ac570178bc
commit 8d1a721bac
2 changed files with 174 additions and 73 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
mailhog/smtp/protocol/protocol.go
View file

@ -15,6 +15,20 @@ import (
type Command struct { type Command struct {
verb string verb string
args string args string
orig string
}
// ParseCommand returns a Command from the line string
func ParseCommand(line string) *Command {
words := strings.Split(line, " ")
command := strings.ToUpper(words[0])
args := strings.Join(words[1:len(words)], " ")
return &Command{
verb: command,
args: args,
orig: line,
}
} }
// Protocol is a state machine representing an SMTP session // Protocol is a state machine representing an SMTP session
@ -139,7 +153,7 @@ func (proto *Protocol) ProcessCommand(line string) (reply *Reply) {
args := strings.Join(words[1:len(words)], " ") args := strings.Join(words[1:len(words)], " ")
proto.logf("In state %d, got command '%s', args '%s'", proto.state, command, args) proto.logf("In state %d, got command '%s', args '%s'", proto.state, command, args)
cmd := &Command{command, args} cmd := ParseCommand(strings.TrimSuffix(line, "\r\n"))
return proto.Command(cmd) return proto.Command(cmd)
} }
@ -172,7 +186,7 @@ func (proto *Protocol) Command(command *Command) (reply *Reply) {
proto.logf("Got PLAIN authentication response: '%s', switching to MAIL state", command.args) proto.logf("Got PLAIN authentication response: '%s', switching to MAIL state", command.args)
proto.state = MAIL proto.state = MAIL
if proto.ValidateAuthenticationHandler != nil { if proto.ValidateAuthenticationHandler != nil {
if reply, ok := proto.ValidateAuthenticationHandler("CRAM-MD5", command.args); !ok { if reply, ok := proto.ValidateAuthenticationHandler("PLAIN", command.orig); !ok {
return reply return reply
} }
} }
@ -185,7 +199,7 @@ func (proto *Protocol) Command(command *Command) (reply *Reply) {
proto.logf("Got LOGIN authentication response: '%s', switching to MAIL state", command.args) proto.logf("Got LOGIN authentication response: '%s', switching to MAIL state", command.args)
proto.state = MAIL proto.state = MAIL
if proto.ValidateAuthenticationHandler != nil { if proto.ValidateAuthenticationHandler != nil {
if reply, ok := proto.ValidateAuthenticationHandler("CRAM-MD5", command.args); !ok { if reply, ok := proto.ValidateAuthenticationHandler("LOGIN", command.orig); !ok {
return reply return reply
} }
} }
@ -194,7 +208,7 @@ func (proto *Protocol) Command(command *Command) (reply *Reply) {
proto.logf("Got CRAM-MD5 authentication response: '%s', switching to MAIL state", command.args) proto.logf("Got CRAM-MD5 authentication response: '%s', switching to MAIL state", command.args)
proto.state = MAIL proto.state = MAIL
if proto.ValidateAuthenticationHandler != nil { if proto.ValidateAuthenticationHandler != nil {
if reply, ok := proto.ValidateAuthenticationHandler("CRAM-MD5", command.args); !ok { if reply, ok := proto.ValidateAuthenticationHandler("CRAM-MD5", command.orig); !ok {
return reply return reply
} }
} }

225
mailhog/smtp/protocol/protocol_test.go
View file

@ -120,10 +120,10 @@ func TestParse(t *testing.T) {
Convey("Parse can call ProcessData", t, func() { Convey("Parse can call ProcessData", t, func() {
proto := NewProtocol() proto := NewProtocol()
proto.Start() proto.Start()
proto.Command(&Command{"EHLO", "localhost"}) proto.Command(ParseCommand("EHLO localhost"))
proto.Command(&Command{"MAIL", "From:<test>"}) proto.Command(ParseCommand("MAIL From:<test>"))
proto.Command(&Command{"RCPT", "To:<test>"}) proto.Command(ParseCommand("RCPT To:<test>"))
proto.Command(&Command{"DATA", ""}) proto.Command(ParseCommand("DATA"))
So(proto.state, ShouldEqual, DATA) So(proto.state, ShouldEqual, DATA)
line, reply := proto.Parse("Hi\n") line, reply := proto.Parse("Hi\n")
@ -150,7 +150,7 @@ func TestUnknownCommands(t *testing.T) {
Convey("Unknown command in INVALID state", t, func() { Convey("Unknown command in INVALID state", t, func() {
proto := NewProtocol() proto := NewProtocol()
So(proto.state, ShouldEqual, INVALID) So(proto.state, ShouldEqual, INVALID)
reply := proto.Command(&Command{"OINK", ""}) reply := proto.Command(ParseCommand("OINK"))
So(reply, ShouldNotBeNil) So(reply, ShouldNotBeNil)
So(reply.Status, ShouldEqual, 500) So(reply.Status, ShouldEqual, 500)
So(reply.Lines(), ShouldResemble, []string{"500 Unrecognised command\n"}) So(reply.Lines(), ShouldResemble, []string{"500 Unrecognised command\n"})
@ -159,7 +159,7 @@ func TestUnknownCommands(t *testing.T) {
proto := NewProtocol() proto := NewProtocol()
proto.Start() proto.Start()
So(proto.state, ShouldEqual, ESTABLISH) So(proto.state, ShouldEqual, ESTABLISH)
reply := proto.Command(&Command{"OINK", ""}) reply := proto.Command(ParseCommand("OINK"))
So(reply, ShouldNotBeNil) So(reply, ShouldNotBeNil)
So(reply.Status, ShouldEqual, 500) So(reply.Status, ShouldEqual, 500)
So(reply.Lines(), ShouldResemble, []string{"500 Unrecognised command\n"}) So(reply.Lines(), ShouldResemble, []string{"500 Unrecognised command\n"})
@ -167,9 +167,9 @@ func TestUnknownCommands(t *testing.T) {
Convey("Unknown command in MAIL state", t, func() { Convey("Unknown command in MAIL state", t, func() {
proto := NewProtocol() proto := NewProtocol()
proto.Start() proto.Start()
proto.Command(&Command{"EHLO", "localhost"}) proto.Command(ParseCommand("EHLO localhost"))
So(proto.state, ShouldEqual, MAIL) So(proto.state, ShouldEqual, MAIL)
reply := proto.Command(&Command{"OINK", ""}) reply := proto.Command(ParseCommand("OINK"))
So(reply, ShouldNotBeNil) So(reply, ShouldNotBeNil)
So(reply.Status, ShouldEqual, 500) So(reply.Status, ShouldEqual, 500)
So(reply.Lines(), ShouldResemble, []string{"500 Unrecognised command\n"}) So(reply.Lines(), ShouldResemble, []string{"500 Unrecognised command\n"})
@ -177,10 +177,10 @@ func TestUnknownCommands(t *testing.T) {
Convey("Unknown command in RCPT state", t, func() { Convey("Unknown command in RCPT state", t, func() {
proto := NewProtocol() proto := NewProtocol()
proto.Start() proto.Start()
proto.Command(&Command{"EHLO", "localhost"}) proto.Command(ParseCommand("EHLO localhost"))
proto.Command(&Command{"MAIL", "FROM:<test>"}) proto.Command(ParseCommand("MAIL FROM:<test>"))
So(proto.state, ShouldEqual, RCPT) So(proto.state, ShouldEqual, RCPT)
reply := proto.Command(&Command{"OINK", ""}) reply := proto.Command(ParseCommand("OINK"))
So(reply, ShouldNotBeNil) So(reply, ShouldNotBeNil)
So(reply.Status, ShouldEqual, 500) So(reply.Status, ShouldEqual, 500)
So(reply.Lines(), ShouldResemble, []string{"500 Unrecognised command\n"}) So(reply.Lines(), ShouldResemble, []string{"500 Unrecognised command\n"})
@ -192,7 +192,7 @@ func TestESTABLISHCommands(t *testing.T) {
proto := NewProtocol() proto := NewProtocol()
proto.Start() proto.Start()
So(proto.state, ShouldEqual, ESTABLISH) So(proto.state, ShouldEqual, ESTABLISH)
reply := proto.Command(&Command{"EHLO", "localhost"}) reply := proto.Command(ParseCommand("EHLO localhost"))
So(reply, ShouldNotBeNil) So(reply, ShouldNotBeNil)
So(reply.Status, ShouldEqual, 250) So(reply.Status, ShouldEqual, 250)
}) })
@ -200,7 +200,7 @@ func TestESTABLISHCommands(t *testing.T) {
proto := NewProtocol() proto := NewProtocol()
proto.Start() proto.Start()
So(proto.state, ShouldEqual, ESTABLISH) So(proto.state, ShouldEqual, ESTABLISH)
reply := proto.Command(&Command{"HELO", "localhost"}) reply := proto.Command(ParseCommand("HELO localhost"))
So(reply, ShouldNotBeNil) So(reply, ShouldNotBeNil)
So(reply.Status, ShouldEqual, 250) So(reply.Status, ShouldEqual, 250)
}) })
@ -208,7 +208,7 @@ func TestESTABLISHCommands(t *testing.T) {
proto := NewProtocol() proto := NewProtocol()
proto.Start() proto.Start()
So(proto.state, ShouldEqual, ESTABLISH) So(proto.state, ShouldEqual, ESTABLISH)
reply := proto.Command(&Command{"RSET", ""}) reply := proto.Command(ParseCommand("RSET"))
So(reply, ShouldNotBeNil) So(reply, ShouldNotBeNil)
So(reply.Status, ShouldEqual, 250) So(reply.Status, ShouldEqual, 250)
}) })
@ -216,7 +216,7 @@ func TestESTABLISHCommands(t *testing.T) {
proto := NewProtocol() proto := NewProtocol()
proto.Start() proto.Start()
So(proto.state, ShouldEqual, ESTABLISH) So(proto.state, ShouldEqual, ESTABLISH)
reply := proto.Command(&Command{"NOOP", ""}) reply := proto.Command(ParseCommand("NOOP"))
So(reply, ShouldNotBeNil) So(reply, ShouldNotBeNil)
So(reply.Status, ShouldEqual, 250) So(reply.Status, ShouldEqual, 250)
}) })
@ -224,7 +224,7 @@ func TestESTABLISHCommands(t *testing.T) {
proto := NewProtocol() proto := NewProtocol()
proto.Start() proto.Start()
So(proto.state, ShouldEqual, ESTABLISH) So(proto.state, ShouldEqual, ESTABLISH)
reply := proto.Command(&Command{"QUIT", ""}) reply := proto.Command(ParseCommand("QUIT"))
So(reply, ShouldNotBeNil) So(reply, ShouldNotBeNil)
So(reply.Status, ShouldEqual, 221) So(reply.Status, ShouldEqual, 221)
}) })
@ -232,7 +232,7 @@ func TestESTABLISHCommands(t *testing.T) {
proto := NewProtocol() proto := NewProtocol()
proto.Start() proto.Start()
So(proto.state, ShouldEqual, ESTABLISH) So(proto.state, ShouldEqual, ESTABLISH)
reply := proto.Command(&Command{"MAIL", ""}) reply := proto.Command(ParseCommand("MAIL"))
So(reply, ShouldNotBeNil) So(reply, ShouldNotBeNil)
So(reply.Status, ShouldEqual, 500) So(reply.Status, ShouldEqual, 500)
So(reply.Lines(), ShouldResemble, []string{"500 Unrecognised command\n"}) So(reply.Lines(), ShouldResemble, []string{"500 Unrecognised command\n"})
@ -241,7 +241,7 @@ func TestESTABLISHCommands(t *testing.T) {
proto := NewProtocol() proto := NewProtocol()
proto.Start() proto.Start()
So(proto.state, ShouldEqual, ESTABLISH) So(proto.state, ShouldEqual, ESTABLISH)
reply := proto.Command(&Command{"RCPT", ""}) reply := proto.Command(ParseCommand("RCPT"))
So(reply, ShouldNotBeNil) So(reply, ShouldNotBeNil)
So(reply.Status, ShouldEqual, 500) So(reply.Status, ShouldEqual, 500)
So(reply.Lines(), ShouldResemble, []string{"500 Unrecognised command\n"}) So(reply.Lines(), ShouldResemble, []string{"500 Unrecognised command\n"})
@ -250,7 +250,7 @@ func TestESTABLISHCommands(t *testing.T) {
proto := NewProtocol() proto := NewProtocol()
proto.Start() proto.Start()
So(proto.state, ShouldEqual, ESTABLISH) So(proto.state, ShouldEqual, ESTABLISH)
reply := proto.Command(&Command{"DATA", ""}) reply := proto.Command(ParseCommand("DATA"))
So(reply, ShouldNotBeNil) So(reply, ShouldNotBeNil)
So(reply.Status, ShouldEqual, 500) So(reply.Status, ShouldEqual, 500)
So(reply.Lines(), ShouldResemble, []string{"500 Unrecognised command\n"}) So(reply.Lines(), ShouldResemble, []string{"500 Unrecognised command\n"})
@ -275,7 +275,7 @@ func TestEHLO(t *testing.T) {
proto.Start() proto.Start()
So(proto.state, ShouldEqual, ESTABLISH) So(proto.state, ShouldEqual, ESTABLISH)
So(proto.message.Helo, ShouldEqual, "") So(proto.message.Helo, ShouldEqual, "")
reply := proto.Command(&Command{"EHLO", "localhost"}) reply := proto.Command(ParseCommand("EHLO localhost"))
So(reply, ShouldNotBeNil) So(reply, ShouldNotBeNil)
So(reply.Status, ShouldEqual, 250) So(reply.Status, ShouldEqual, 250)
So(reply.Lines(), ShouldResemble, []string{"250-Hello localhost\n", "250-PIPELINING\n", "250 AUTH EXTERNAL CRAM-MD5 LOGIN PLAIN\n"}) So(reply.Lines(), ShouldResemble, []string{"250-Hello localhost\n", "250-PIPELINING\n", "250 AUTH EXTERNAL CRAM-MD5 LOGIN PLAIN\n"})
@ -285,10 +285,10 @@ func TestEHLO(t *testing.T) {
Convey("HELO should work in MAIL state", t, func() { Convey("HELO should work in MAIL state", t, func() {
proto := NewProtocol() proto := NewProtocol()
proto.Start() proto.Start()
proto.Command(&Command{"HELO", "localhost"}) proto.Command(ParseCommand("HELO localhost"))
So(proto.state, ShouldEqual, MAIL) So(proto.state, ShouldEqual, MAIL)
So(proto.message.Helo, ShouldEqual, "localhost") So(proto.message.Helo, ShouldEqual, "localhost")
reply := proto.Command(&Command{"EHLO", "localhost"}) reply := proto.Command(ParseCommand("EHLO localhost"))
So(reply, ShouldNotBeNil) So(reply, ShouldNotBeNil)
So(reply.Status, ShouldEqual, 250) So(reply.Status, ShouldEqual, 250)
So(reply.Lines(), ShouldResemble, []string{"250-Hello localhost\n", "250-PIPELINING\n", "250 AUTH EXTERNAL CRAM-MD5 LOGIN PLAIN\n"}) So(reply.Lines(), ShouldResemble, []string{"250-Hello localhost\n", "250-PIPELINING\n", "250 AUTH EXTERNAL CRAM-MD5 LOGIN PLAIN\n"})
@ -298,11 +298,11 @@ func TestEHLO(t *testing.T) {
Convey("HELO should work in RCPT state", t, func() { Convey("HELO should work in RCPT state", t, func() {
proto := NewProtocol() proto := NewProtocol()
proto.Start() proto.Start()
proto.Command(&Command{"HELO", "localhost"}) proto.Command(ParseCommand("HELO localhost"))
proto.Command(&Command{"MAIL", "From:<test>"}) proto.Command(ParseCommand("MAIL From:<test>"))
So(proto.state, ShouldEqual, RCPT) So(proto.state, ShouldEqual, RCPT)
So(proto.message.Helo, ShouldEqual, "localhost") So(proto.message.Helo, ShouldEqual, "localhost")
reply := proto.Command(&Command{"EHLO", "localhost"}) reply := proto.Command(ParseCommand("EHLO localhost"))
So(reply, ShouldNotBeNil) So(reply, ShouldNotBeNil)
So(reply.Status, ShouldEqual, 250) So(reply.Status, ShouldEqual, 250)
So(reply.Lines(), ShouldResemble, []string{"250-Hello localhost\n", "250-PIPELINING\n", "250 AUTH EXTERNAL CRAM-MD5 LOGIN PLAIN\n"}) So(reply.Lines(), ShouldResemble, []string{"250-Hello localhost\n", "250-PIPELINING\n", "250 AUTH EXTERNAL CRAM-MD5 LOGIN PLAIN\n"})
@ -329,7 +329,7 @@ func TestHELO(t *testing.T) {
proto.Start() proto.Start()
So(proto.state, ShouldEqual, ESTABLISH) So(proto.state, ShouldEqual, ESTABLISH)
So(proto.message.Helo, ShouldEqual, "") So(proto.message.Helo, ShouldEqual, "")
reply := proto.Command(&Command{"HELO", "localhost"}) reply := proto.Command(ParseCommand("HELO localhost"))
So(reply, ShouldNotBeNil) So(reply, ShouldNotBeNil)
So(reply.Status, ShouldEqual, 250) So(reply.Status, ShouldEqual, 250)
So(reply.Lines(), ShouldResemble, []string{"250 Hello localhost\n"}) So(reply.Lines(), ShouldResemble, []string{"250 Hello localhost\n"})
@ -339,10 +339,10 @@ func TestHELO(t *testing.T) {
Convey("HELO should work in MAIL state", t, func() { Convey("HELO should work in MAIL state", t, func() {
proto := NewProtocol() proto := NewProtocol()
proto.Start() proto.Start()
proto.Command(&Command{"HELO", "localhost"}) proto.Command(ParseCommand("HELO localhost"))
So(proto.state, ShouldEqual, MAIL) So(proto.state, ShouldEqual, MAIL)
So(proto.message.Helo, ShouldEqual, "localhost") So(proto.message.Helo, ShouldEqual, "localhost")
reply := proto.Command(&Command{"HELO", "localhost"}) reply := proto.Command(ParseCommand("HELO localhost"))
So(reply, ShouldNotBeNil) So(reply, ShouldNotBeNil)
So(reply.Status, ShouldEqual, 250) So(reply.Status, ShouldEqual, 250)
So(reply.Lines(), ShouldResemble, []string{"250 Hello localhost\n"}) So(reply.Lines(), ShouldResemble, []string{"250 Hello localhost\n"})
@ -352,11 +352,11 @@ func TestHELO(t *testing.T) {
Convey("HELO should work in RCPT state", t, func() { Convey("HELO should work in RCPT state", t, func() {
proto := NewProtocol() proto := NewProtocol()
proto.Start() proto.Start()
proto.Command(&Command{"HELO", "localhost"}) proto.Command(ParseCommand("HELO localhost"))
proto.Command(&Command{"MAIL", "From:<test>"}) proto.Command(ParseCommand("MAIL From:<test>"))
So(proto.state, ShouldEqual, RCPT) So(proto.state, ShouldEqual, RCPT)
So(proto.message.Helo, ShouldEqual, "localhost") So(proto.message.Helo, ShouldEqual, "localhost")
reply := proto.Command(&Command{"HELO", "localhost"}) reply := proto.Command(ParseCommand("HELO localhost"))
So(reply, ShouldNotBeNil) So(reply, ShouldNotBeNil)
So(reply.Status, ShouldEqual, 250) So(reply.Status, ShouldEqual, 250)
So(reply.Lines(), ShouldResemble, []string{"250 Hello localhost\n"}) So(reply.Lines(), ShouldResemble, []string{"250 Hello localhost\n"})
@ -375,9 +375,9 @@ func TestDATA(t *testing.T) {
} }
proto.Start() proto.Start()
proto.HELO("localhost") proto.HELO("localhost")
proto.Command(&Command{"MAIL", "FROM:<test>"}) proto.Command(ParseCommand("MAIL FROM:<test>"))
proto.Command(&Command{"RCPT", "TO:<test>"}) proto.Command(ParseCommand("RCPT TO:<test>"))
reply := proto.Command(&Command{"DATA", ""}) reply := proto.Command(ParseCommand("DATA"))
So(reply, ShouldNotBeNil) So(reply, ShouldNotBeNil)
So(reply.Status, ShouldEqual, 354) So(reply.Status, ShouldEqual, 354)
So(reply.Lines(), ShouldResemble, []string{"354 End data with <CR><LF>.<CR><LF>\n"}) So(reply.Lines(), ShouldResemble, []string{"354 End data with <CR><LF>.<CR><LF>\n"})
@ -401,9 +401,9 @@ func TestDATA(t *testing.T) {
proto := NewProtocol() proto := NewProtocol()
proto.Start() proto.Start()
proto.HELO("localhost") proto.HELO("localhost")
proto.Command(&Command{"MAIL", "FROM:<test>"}) proto.Command(ParseCommand("MAIL FROM:<test>"))
proto.Command(&Command{"RCPT", "TO:<test>"}) proto.Command(ParseCommand("RCPT TO:<test>"))
reply := proto.Command(&Command{"DATA", ""}) reply := proto.Command(ParseCommand("DATA"))
So(reply, ShouldNotBeNil) So(reply, ShouldNotBeNil)
So(reply.Status, ShouldEqual, 354) So(reply.Status, ShouldEqual, 354)
So(reply.Lines(), ShouldResemble, []string{"354 End data with <CR><LF>.<CR><LF>\n"}) So(reply.Lines(), ShouldResemble, []string{"354 End data with <CR><LF>.<CR><LF>\n"})
@ -431,9 +431,9 @@ func TestDATA(t *testing.T) {
} }
proto.Start() proto.Start()
proto.HELO("localhost") proto.HELO("localhost")
proto.Command(&Command{"MAIL", "FROM:<test>"}) proto.Command(ParseCommand("MAIL FROM:<test>"))
proto.Command(&Command{"RCPT", "TO:<test>"}) proto.Command(ParseCommand("RCPT TO:<test>"))
reply := proto.Command(&Command{"DATA", ""}) reply := proto.Command(ParseCommand("DATA"))
So(reply, ShouldNotBeNil) So(reply, ShouldNotBeNil)
So(reply.Status, ShouldEqual, 354) So(reply.Status, ShouldEqual, 354)
So(reply.Lines(), ShouldResemble, []string{"354 End data with <CR><LF>.<CR><LF>\n"}) So(reply.Lines(), ShouldResemble, []string{"354 End data with <CR><LF>.<CR><LF>\n"})
@ -460,13 +460,13 @@ func TestRSET(t *testing.T) {
proto := NewProtocol() proto := NewProtocol()
proto.Start() proto.Start()
proto.HELO("localhost") proto.HELO("localhost")
proto.Command(&Command{"MAIL", "FROM:<test>"}) proto.Command(ParseCommand("MAIL FROM:<test>"))
proto.Command(&Command{"RCPT", "TO:<test>"}) proto.Command(ParseCommand("RCPT TO:<test>"))
So(proto.state, ShouldEqual, RCPT) So(proto.state, ShouldEqual, RCPT)
So(proto.message.From, ShouldEqual, "test") So(proto.message.From, ShouldEqual, "test")
So(len(proto.message.To), ShouldEqual, 1) So(len(proto.message.To), ShouldEqual, 1)
So(proto.message.To[0], ShouldEqual, "test") So(proto.message.To[0], ShouldEqual, "test")
reply := proto.Command(&Command{"RSET", ""}) reply := proto.Command(ParseCommand("RSET"))
So(reply, ShouldNotBeNil) So(reply, ShouldNotBeNil)
So(reply.Status, ShouldEqual, 250) So(reply.Status, ShouldEqual, 250)
So(reply.Lines(), ShouldResemble, []string{"250 Ok\n"}) So(reply.Lines(), ShouldResemble, []string{"250 Ok\n"})
@ -481,13 +481,13 @@ func TestNOOP(t *testing.T) {
proto := NewProtocol() proto := NewProtocol()
proto.Start() proto.Start()
proto.HELO("localhost") proto.HELO("localhost")
proto.Command(&Command{"MAIL", "FROM:<test>"}) proto.Command(ParseCommand("MAIL FROM:<test>"))
proto.Command(&Command{"RCPT", "TO:<test>"}) proto.Command(ParseCommand("RCPT TO:<test>"))
So(proto.state, ShouldEqual, RCPT) So(proto.state, ShouldEqual, RCPT)
So(proto.message.From, ShouldEqual, "test") So(proto.message.From, ShouldEqual, "test")
So(len(proto.message.To), ShouldEqual, 1) So(len(proto.message.To), ShouldEqual, 1)
So(proto.message.To[0], ShouldEqual, "test") So(proto.message.To[0], ShouldEqual, "test")
reply := proto.Command(&Command{"NOOP", ""}) reply := proto.Command(ParseCommand("NOOP"))
So(reply, ShouldNotBeNil) So(reply, ShouldNotBeNil)
So(reply.Status, ShouldEqual, 250) So(reply.Status, ShouldEqual, 250)
So(reply.Lines(), ShouldResemble, []string{"250 Ok\n"}) So(reply.Lines(), ShouldResemble, []string{"250 Ok\n"})
@ -502,7 +502,7 @@ func TestQUIT(t *testing.T) {
Convey("QUIT should modify the state correctly", t, func() { Convey("QUIT should modify the state correctly", t, func() {
proto := NewProtocol() proto := NewProtocol()
proto.Start() proto.Start()
reply := proto.Command(&Command{"QUIT", ""}) reply := proto.Command(ParseCommand("QUIT"))
So(proto.state, ShouldEqual, DONE) So(proto.state, ShouldEqual, DONE)
So(reply, ShouldNotBeNil) So(reply, ShouldNotBeNil)
So(reply.Status, ShouldEqual, 221) So(reply.Status, ShouldEqual, 221)
@ -539,9 +539,9 @@ func TestParseMAIL(t *testing.T) {
Convey("Error should be returned via Command", t, func() { Convey("Error should be returned via Command", t, func() {
proto := NewProtocol() proto := NewProtocol()
proto.Start() proto.Start()
proto.Command(&Command{"HELO", "localhost"}) proto.Command(ParseCommand("HELO localhost"))
So(proto.state, ShouldEqual, MAIL) So(proto.state, ShouldEqual, MAIL)
reply := proto.Command(&Command{"MAIL", "oink"}) reply := proto.Command(ParseCommand("MAIL oink"))
So(reply, ShouldNotBeNil) So(reply, ShouldNotBeNil)
So(reply.Status, ShouldEqual, 550) So(reply.Status, ShouldEqual, 550)
So(reply.Lines(), ShouldResemble, []string{"550 Invalid syntax in MAIL command\n"}) So(reply.Lines(), ShouldResemble, []string{"550 Invalid syntax in MAIL command\n"})
@ -556,9 +556,9 @@ func TestParseMAIL(t *testing.T) {
return true return true
} }
proto.Start() proto.Start()
proto.Command(&Command{"HELO", "localhost"}) proto.Command(ParseCommand("HELO localhost"))
So(proto.state, ShouldEqual, MAIL) So(proto.state, ShouldEqual, MAIL)
reply := proto.Command(&Command{"MAIL", "From:<oink@mailhog.example>"}) reply := proto.Command(ParseCommand("MAIL From:<oink@mailhog.example>"))
So(handlerCalled, ShouldBeTrue) So(handlerCalled, ShouldBeTrue)
So(reply, ShouldNotBeNil) So(reply, ShouldNotBeNil)
So(reply.Status, ShouldEqual, 250) So(reply.Status, ShouldEqual, 250)
@ -574,9 +574,9 @@ func TestParseMAIL(t *testing.T) {
return false return false
} }
proto.Start() proto.Start()
proto.Command(&Command{"HELO", "localhost"}) proto.Command(ParseCommand("HELO localhost"))
So(proto.state, ShouldEqual, MAIL) So(proto.state, ShouldEqual, MAIL)
reply := proto.Command(&Command{"MAIL", "From:<oink@mailhog.example>"}) reply := proto.Command(ParseCommand("MAIL From:<oink@mailhog.example>"))
So(handlerCalled, ShouldBeTrue) So(handlerCalled, ShouldBeTrue)
So(reply, ShouldNotBeNil) So(reply, ShouldNotBeNil)
So(reply.Status, ShouldEqual, 550) So(reply.Status, ShouldEqual, 550)
@ -614,10 +614,10 @@ func TestParseRCPT(t *testing.T) {
Convey("Error should be returned via Command", t, func() { Convey("Error should be returned via Command", t, func() {
proto := NewProtocol() proto := NewProtocol()
proto.Start() proto.Start()
proto.Command(&Command{"HELO", "localhost"}) proto.Command(ParseCommand("HELO localhost"))
proto.Command(&Command{"MAIL", "FROM:<test>"}) proto.Command(ParseCommand("MAIL FROM:<test>"))
So(proto.state, ShouldEqual, RCPT) So(proto.state, ShouldEqual, RCPT)
reply := proto.Command(&Command{"RCPT", "oink"}) reply := proto.Command(ParseCommand("RCPT oink"))
So(reply, ShouldNotBeNil) So(reply, ShouldNotBeNil)
So(reply.Status, ShouldEqual, 550) So(reply.Status, ShouldEqual, 550)
So(reply.Lines(), ShouldResemble, []string{"550 Invalid syntax in RCPT command\n"}) So(reply.Lines(), ShouldResemble, []string{"550 Invalid syntax in RCPT command\n"})
@ -632,10 +632,10 @@ func TestParseRCPT(t *testing.T) {
return true return true
} }
proto.Start() proto.Start()
proto.Command(&Command{"HELO", "localhost"}) proto.Command(ParseCommand("HELO localhost"))
proto.Command(&Command{"MAIL", "FROM:<test>"}) proto.Command(ParseCommand("MAIL FROM:<test>"))
So(proto.state, ShouldEqual, RCPT) So(proto.state, ShouldEqual, RCPT)
reply := proto.Command(&Command{"RCPT", "To:<oink@mailhog.example>"}) reply := proto.Command(ParseCommand("RCPT To:<oink@mailhog.example>"))
So(handlerCalled, ShouldBeTrue) So(handlerCalled, ShouldBeTrue)
So(reply, ShouldNotBeNil) So(reply, ShouldNotBeNil)
So(reply.Status, ShouldEqual, 250) So(reply.Status, ShouldEqual, 250)
@ -651,10 +651,10 @@ func TestParseRCPT(t *testing.T) {
return false return false
} }
proto.Start() proto.Start()
proto.Command(&Command{"HELO", "localhost"}) proto.Command(ParseCommand("HELO localhost"))
proto.Command(&Command{"MAIL", "FROM:<test>"}) proto.Command(ParseCommand("MAIL FROM:<test>"))
So(proto.state, ShouldEqual, RCPT) So(proto.state, ShouldEqual, RCPT)
reply := proto.Command(&Command{"RCPT", "To:<oink@mailhog.example>"}) reply := proto.Command(ParseCommand("RCPT To:<oink@mailhog.example>"))
So(handlerCalled, ShouldBeTrue) So(handlerCalled, ShouldBeTrue)
So(reply, ShouldNotBeNil) So(reply, ShouldNotBeNil)
So(reply.Status, ShouldEqual, 550) So(reply.Status, ShouldEqual, 550)
@ -667,7 +667,7 @@ func TestAuth(t *testing.T) {
Convey("AUTH should be listed in EHLO response", t, func() { Convey("AUTH should be listed in EHLO response", t, func() {
proto := NewProtocol() proto := NewProtocol()
proto.Start() proto.Start()
reply := proto.Command(&Command{"EHLO", "localhost"}) reply := proto.Command(ParseCommand("EHLO localhost"))
So(reply, ShouldNotBeNil) So(reply, ShouldNotBeNil)
So(reply.Status, ShouldEqual, 250) So(reply.Status, ShouldEqual, 250)
So(reply.Lines(), ShouldResemble, []string{"250-Hello localhost\n", "250-PIPELINING\n", "250 AUTH EXTERNAL CRAM-MD5 LOGIN PLAIN\n"}) So(reply.Lines(), ShouldResemble, []string{"250-Hello localhost\n", "250-PIPELINING\n", "250 AUTH EXTERNAL CRAM-MD5 LOGIN PLAIN\n"})
@ -676,13 +676,15 @@ func TestAuth(t *testing.T) {
Convey("Invalid mechanism should be rejected", t, func() { Convey("Invalid mechanism should be rejected", t, func() {
proto := NewProtocol() proto := NewProtocol()
proto.Start() proto.Start()
proto.Command(&Command{"EHLO", "localhost"}) proto.Command(ParseCommand("EHLO localhost"))
reply := proto.Command(&Command{"AUTH", "OINK"}) reply := proto.Command(ParseCommand("AUTH OINK"))
So(reply, ShouldNotBeNil) So(reply, ShouldNotBeNil)
So(reply.Status, ShouldEqual, 504) So(reply.Status, ShouldEqual, 504)
So(reply.Lines(), ShouldResemble, []string{"504 Unsupported authentication mechanism\n"}) So(reply.Lines(), ShouldResemble, []string{"504 Unsupported authentication mechanism\n"})
}) })
}
func TestAuthExternal(t *testing.T) {
Convey("AUTH EXTERNAL should call ValidateAuthenticationHandler", t, func() { Convey("AUTH EXTERNAL should call ValidateAuthenticationHandler", t, func() {
proto := NewProtocol() proto := NewProtocol()
handlerCalled := false handlerCalled := false
@ -694,8 +696,11 @@ func TestAuth(t *testing.T) {
return nil, true return nil, true
} }
proto.Start() proto.Start()
proto.Command(&Command{"EHLO", "localhost"}) proto.Command(ParseCommand("EHLO localhost"))
proto.Command(&Command{"AUTH", "EXTERNAL oink!"}) reply := proto.Command(ParseCommand("AUTH EXTERNAL oink!"))
So(reply, ShouldNotBeNil)
So(reply.Status, ShouldEqual, 235)
So(reply.Lines(), ShouldResemble, []string{"235 Authentication successful\n"})
So(handlerCalled, ShouldBeTrue) So(handlerCalled, ShouldBeTrue)
}) })
@ -707,8 +712,90 @@ func TestAuth(t *testing.T) {
return ReplyError(errors.New("OINK :(")), false return ReplyError(errors.New("OINK :(")), false
} }
proto.Start() proto.Start()
proto.Command(&Command{"EHLO", "localhost"}) proto.Command(ParseCommand("EHLO localhost"))
reply := proto.Command(&Command{"AUTH", "EXTERNAL oink!"}) reply := proto.Command(ParseCommand("AUTH EXTERNAL oink!"))
So(reply, ShouldNotBeNil)
So(reply.Status, ShouldEqual, 550)
So(reply.Lines(), ShouldResemble, []string{"550 OINK :(\n"})
So(handlerCalled, ShouldBeTrue)
})
}
func TestAuthPlain(t *testing.T) {
Convey("Inline AUTH PLAIN should call ValidateAuthenticationHandler", t, func() {
proto := NewProtocol()
handlerCalled := false
proto.ValidateAuthenticationHandler = func(mechanism string, args ...string) (*Reply, bool) {
handlerCalled = true
So(mechanism, ShouldEqual, "PLAIN")
So(len(args), ShouldEqual, 1)
So(args[0], ShouldEqual, "oink!")
return nil, true
}
proto.Start()
proto.Command(ParseCommand("EHLO localhost"))
reply := proto.Command(ParseCommand("AUTH PLAIN oink!"))
So(reply, ShouldNotBeNil)
So(reply.Status, ShouldEqual, 235)
So(reply.Lines(), ShouldResemble, []string{"235 Authentication successful\n"})
So(handlerCalled, ShouldBeTrue)
})
Convey("Inline AUTH PLAIN ValidateAuthenticationHandler errors should be returned", t, func() {
proto := NewProtocol()
handlerCalled := false
proto.ValidateAuthenticationHandler = func(mechanism string, args ...string) (*Reply, bool) {
handlerCalled = true
return ReplyError(errors.New("OINK :(")), false
}
proto.Start()
proto.Command(ParseCommand("EHLO localhost"))
reply := proto.Command(ParseCommand("AUTH PLAIN oink!"))
So(reply, ShouldNotBeNil)
So(reply.Status, ShouldEqual, 550)
So(reply.Lines(), ShouldResemble, []string{"550 OINK :(\n"})
So(handlerCalled, ShouldBeTrue)
})
Convey("Two part AUTH PLAIN should call ValidateAuthenticationHandler", t, func() {
proto := NewProtocol()
handlerCalled := false
proto.ValidateAuthenticationHandler = func(mechanism string, args ...string) (*Reply, bool) {
handlerCalled = true
So(mechanism, ShouldEqual, "PLAIN")
So(len(args), ShouldEqual, 1)
So(args[0], ShouldEqual, "oink!")
return nil, true
}
proto.Start()
proto.Command(ParseCommand("EHLO localhost"))
reply := proto.Command(ParseCommand("AUTH PLAIN"))
So(reply, ShouldNotBeNil)
So(reply.Status, ShouldEqual, 334)
So(reply.Lines(), ShouldResemble, []string{"334 \n"})
_, reply = proto.Parse("oink!\n")
So(reply, ShouldNotBeNil)
So(reply.Status, ShouldEqual, 235)
So(reply.Lines(), ShouldResemble, []string{"235 Authentication successful\n"})
So(handlerCalled, ShouldBeTrue)
})
Convey("Two part AUTH PLAIN ValidateAuthenticationHandler errors should be returned", t, func() {
proto := NewProtocol()
handlerCalled := false
proto.ValidateAuthenticationHandler = func(mechanism string, args ...string) (*Reply, bool) {
handlerCalled = true
return ReplyError(errors.New("OINK :(")), false
}
proto.Start()
proto.Command(ParseCommand("EHLO localhost"))
reply := proto.Command(ParseCommand("AUTH PLAIN"))
So(reply, ShouldNotBeNil)
So(reply.Status, ShouldEqual, 334)
So(reply.Lines(), ShouldResemble, []string{"334 \n"})
_, reply = proto.Parse("oink!\n")
So(reply, ShouldNotBeNil) So(reply, ShouldNotBeNil)
So(reply.Status, ShouldEqual, 550) So(reply.Status, ShouldEqual, 550)
So(reply.Lines(), ShouldResemble, []string{"550 OINK :(\n"}) So(reply.Lines(), ShouldResemble, []string{"550 OINK :(\n"})