make release versions tags

atlasnetwork commented

2017-02-16 17:03:22 +00:00

(Migrated from github.com)

Occasionally, using the latest tag, new updates will break existing deployments. For example, the addition of REAL IP / X-Forwarded-For Headers for deployments behind ELBs caused some issues.

Using version numbers as tags for docker image builds would allow for people to update on their own schedule, and those that wish can stay on the latest tag.

Occasionally, using the latest tag, new updates will break existing deployments. For example, the addition of REAL IP / X-Forwarded-For Headers for deployments behind ELBs caused some issues. Using version numbers as tags for docker image builds would allow for people to update on their own schedule, and those that wish can stay on the latest tag.

richarvey commented

2017-02-16 17:23:10 +00:00

(Migrated from github.com)

Agreed, this is on my todo, i'm looking to do github versions and also open an LTS tag in docker hub that will be semver , however I'm open to suggestions.

atlasnetwork commented

2017-02-16 17:28:43 +00:00

(Migrated from github.com)

That sounds great, thank you. If you are looking for a good example, I
feel that https://github.com/sameersbn/docker-gitlab /
https://hub.docker.com/r/sameersbn/gitlab/ has done a good job of it.

Thanks for sharing this project.

On Thu, Feb 16, 2017 at 12:23 PM, Ric Harvey notifications@github.com
wrote:

Agreed, this is on my todo, i'm looking to do github versions and also
open an LTS tag in docker hub that will be semver , however I'm open to
suggestions.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ngineered/nginx-php-fpm/issues/114#issuecomment-280397994,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AS_YubRgdWJwxClq0ueEKy3HQEO0mHuBks5rdIX_gaJpZM4MDR7S
.

That sounds great, thank you. If you are looking for a good example, I feel that https://github.com/sameersbn/docker-gitlab / https://hub.docker.com/r/sameersbn/gitlab/ has done a good job of it. Thanks for sharing this project. On Thu, Feb 16, 2017 at 12:23 PM, Ric Harvey <notifications@github.com> wrote: > Agreed, this is on my todo, i'm looking to do github versions and also > open an LTS tag in docker hub that will be semver , however I'm open to > suggestions. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/ngineered/nginx-php-fpm/issues/114#issuecomment-280397994>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AS_YubRgdWJwxClq0ueEKy3HQEO0mHuBks5rdIX_gaJpZM4MDR7S> > . >

richarvey commented

2017-02-16 17:29:57 +00:00

(Migrated from github.com)

@sameerbn does great work :) will take a look

richarvey commented

2017-02-17 11:11:31 +00:00

(Migrated from github.com)

This is underway, starting with 1.1.1 with 1.1.2 to follow shortly. The documentation as of 1.1.2 will also explain the versioning.

👍 1

Rows
Columns

make release versions tags #114