iPadOS version running on MacOS #1
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
When opening the search section on MacOS (using the iPad install) The app crashes and quits unexpectedly.
Fixed in TestFlight build 202610091617 of the iPhone and iPad app, by ric/peertube-ios@3b0859e.
What happened. Opening Search was fine; the app quit when the search box was clicked. Reproduced on a Mac mini (macOS 27.0.1) with build 202610022027, and the crash report shows an assertion inside UIKit, with none of the app's own code on the stack:
Making the system's search field active has UIKit hide the tab bar and lay the search out again. On macOS 27 that layout asks the screen which window has the focus, and UIKit on a Mac answers with an assertion ("screen-based focus unsupported"), which ends the app. It only happens when the iPad app runs on a Mac. It does not happen on iPhone or iPad, in the simulator, or in a Mac Catalyst build.
The fix. On a Mac, Search no longer uses the system's search field. The page has a plain text field of its own, with "Whole network" and the instance's name under it to choose where to search, and Search is a tab like the others. iPhone and iPad are unchanged.
Checked. Build 202610091617 from TestFlight on the same Mac: clicked in the field, typed, searched, switched where to search. No crash. On the simulators, 236 unit tests pass, and the search UI tests pass on iPhone and iPad, including two new ones: one that types into the system's field (the old test never made it active, which is how this got through) and one that runs the Mac's field.
Still to do, separately. Switching to search only the instance shows "Incorrect request parameters: sort" on tilvids.com. That is a different fault and not new: PeerTube 8.2 and later refuse the
-bestsort onsearch/videos. It affects iPhone, iPad and Apple TV too.The build that is waiting for App Review (202610022027) still has this crash on a Mac.