Lab Feedback #45

Closed
opened 2019-07-23 20:25:08 +00:00 by JGMSoftware · 2 comments
JGMSoftware commented 2019-07-23 20:25:08 +00:00 (Migrated from github.com)

Hi folks, I attended the workshop in London last week and I'm running through the labs again. I've got some feedback/suggested changes for Lab 2 - as I go through the labs, if I find anything would you rather I reported them as issues or opened PRs for them?

In Lab 2, Step 4, the CloudFormation deploys a second public subnet with MapPublicIpOnLaunch: false - is this intentional? I don't think this could lead to unintended consequences within the lab material, but if someone is trying to extend it for themselves then it may lead to confusion if they deploy their own instances.

Similarly, in Step 6, the CloudFormation deploys two private subnets with MapPublicIpOnLaunch: true - I don't think this makes sense in the context of a private subnet?

Hi folks, I attended the workshop in London last week and I'm running through the labs again. I've got some feedback/suggested changes for Lab 2 - as I go through the labs, if I find anything would you rather I reported them as issues or opened PRs for them? In Lab 2, Step 4, the CloudFormation deploys a second public subnet with `MapPublicIpOnLaunch: false` - is this intentional? I don't think this could lead to unintended consequences within the lab material, but if someone is trying to extend it for themselves then it may lead to confusion if they deploy their own instances. Similarly, in Step 6, the CloudFormation deploys two private subnets with `MapPublicIpOnLaunch: true` - I don't think this makes sense in the context of a private subnet?
richarvey commented 2019-07-24 08:00:51 +00:00 (Migrated from github.com)

Good spot, we'll get this fixed asap.

Good spot, we'll get this fixed asap.
richarvey commented 2019-07-25 09:47:46 +00:00 (Migrated from github.com)

this fix applies to lab2+ for MapPublicIpOnLaunch, will push change asap.

this fix applies to lab2+ for MapPublicIpOnLaunch, will push change asap.
Sign in to join this conversation.
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
ric/techshift-modernise#45
No description provided.