ric/uptime-kuma
1
0
Fork 0
mirror of https://github.com/louislam/uptime-kuma.git synced 2024-11-23 14:54:05 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Updated code comments

Browse source
This commit is contained in:
Matt Visnovsky 2024-05-03 11:52:02 -06:00
parent c87ac2f043
commit 09fd816aae
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
server/monitor-types/snmp.js
View file

@ -14,6 +14,9 @@ class SNMPMonitorType extends MonitorType {
port: monitor.port || "161", port: monitor.port || "161",
retries: monitor.maxretries, retries: monitor.maxretries,
timeout: monitor.timeout * 1000, timeout: monitor.timeout * 1000,
// Resolve the net-snmp version identifier from monitor.snmpVersion using the `getKey` method (see utils.ts).
// If the specified version exists, use it; otherwise, default to SNMP version 2c.
version: getKey(snmp.Version, monitor.snmpVersion) || snmp.Version2c, version: getKey(snmp.Version, monitor.snmpVersion) || snmp.Version2c,
}; };
@ -38,9 +41,14 @@ class SNMPMonitorType extends MonitorType {
}); });
}); });
// Verify if any varbinds were returned from the SNMP session or if the varbind type indicates a non-existent instance.
// The `getKey` method retrieves the key associated with the varbind type from the snmp.ObjectType object.
if (varbinds.length === 0 || getKey(snmp.ObjectType, varbinds[0].type) === "NoSuchInstance") { if (varbinds.length === 0 || getKey(snmp.ObjectType, varbinds[0].type) === "NoSuchInstance") {
throw new Error(`No varbinds returned from SNMP session (OID: ${monitor.snmpOid})`); throw new Error(`No varbinds returned from SNMP session (OID: ${monitor.snmpOid})`);
// Varbinds succesfully returned
} else { } else {
const value = varbinds[0].value; const value = varbinds[0].value;
// Check if inputs are numeric. If not, re-parse as strings. This ensures comparisons are handled correctly. // Check if inputs are numeric. If not, re-parse as strings. This ensures comparisons are handled correctly.