ric/uptime-kuma
1
0
Fork 0
mirror of https://github.com/louislam/uptime-kuma.git synced 2024-11-23 23:04:04 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Ensure SNMP session is closed properly

Browse source 
Addresses https://github.com/louislam/uptime-kuma/pull/4717#discussion_r1589858252

Co-Authored-By: Frank Elsinga <frank.elsinga@tum.de>
This commit is contained in:
Matt Visnovsky 2024-05-06 15:56:41 -06:00
parent f4842ead68
commit 2b5d100cd3
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
server/monitor-types/snmp.js
View file

@ -17,8 +17,9 @@ class SNMPMonitorType extends MonitorType {
version: parseInt(monitor.snmpVersion), version: parseInt(monitor.snmpVersion),
}; };
let session;
try { try {
const session = snmp.createSession(monitor.hostname, monitor.snmpCommunityString, options); session = snmp.createSession(monitor.hostname, monitor.snmpCommunityString, options);
// Handle errors during session creation // Handle errors during session creation
session.on("error", (error) => { session.on("error", (error) => {
@ -77,11 +78,13 @@ class SNMPMonitorType extends MonitorType {
} }
heartbeat.msg = "SNMP value " + (heartbeat.status ? "passes" : "does not pass") + ` comparison: ${value.toString()} ${monitor.snmpCondition} ${snmpControlValue}`; heartbeat.msg = "SNMP value " + (heartbeat.status ? "passes" : "does not pass") + ` comparison: ${value.toString()} ${monitor.snmpCondition} ${snmpControlValue}`;
session.close();
} catch (err) { } catch (err) {
heartbeat.status = DOWN; heartbeat.status = DOWN;
heartbeat.msg = `SNMP Error: ${err.message}`; heartbeat.msg = `SNMP Error: ${err.message}`;
} finally {
if (session) {
session.close();
}
} }
} }