ric/uptime-kuma
1
0
Fork 0
mirror of https://github.com/louislam/uptime-kuma.git synced 2024-11-23 23:04:04 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Apply suggestions from code review

Browse source 
Addresses:
-https://github.com/louislam/uptime-kuma/pull/4717#discussion_r1589805237
-https://github.com/louislam/uptime-kuma/pull/4717#discussion_r1589806199
-https://github.com/louislam/uptime-kuma/pull/4717#discussion_r1589853470
-https://github.com/louislam/uptime-kuma/pull/4717#discussion_r1589854032
This commit is contained in:
Matt Visnovsky 2024-05-05 15:47:43 -06:00
parent 9053b48030
commit 4386d0afad
2 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
server/monitor-types/snmp.js
View file

@ -25,9 +25,7 @@ class SNMPMonitorType extends MonitorType {
// Handle errors during session creation // Handle errors during session creation
session.on("error", (error) => { session.on("error", (error) => {
heartbeat.status = DOWN; throw new Error(`Error creating SNMP session: ${error.message}`);
heartbeat.msg = `SNMP: Error creating SNMP session: ${error.message}`;
log.debug("monitor", heartbeat.msg);
}); });
const varbinds = await new Promise((resolve, reject) => { const varbinds = await new Promise((resolve, reject) => {
@ -35,11 +33,11 @@ class SNMPMonitorType extends MonitorType {
if (error) { if (error) {
reject(error); reject(error);
} else { } else {
log.debug("monitor", `SNMP: Received varbinds (Type=${getKey(snmp.ObjectType, varbinds[0].type)}): ${varbinds[0].value}`);
resolve(varbinds); resolve(varbinds);
} }
}); });
}); });
log.debug("monitor", `SNMP: Received varbinds (Type=${getKey(snmp.ObjectType, varbinds[0].type)}): ${varbinds[0].value}`);
// Verify if any varbinds were returned from the SNMP session or if the varbind type indicates a non-existent instance. // Verify if any varbinds were returned from the SNMP session or if the varbind type indicates a non-existent instance.
// The `getKey` method retrieves the key associated with the varbind type from the snmp.ObjectType object. // The `getKey` method retrieves the key associated with the varbind type from the snmp.ObjectType object.

6
src/pages/EditMonitor.vue
View file

@ -1320,11 +1320,13 @@ message HealthCheckResponse {
} }
} }
// Set default timeout // Set a default timeout of 1 second for SNMP monitors when querying a single OID.
// Since we're only querying a single OID, a shorter timeout is sufficient to ensure timely responses
// without unnecessary delays. This helps keep the monitoring process lightweight and efficient.
if (this.monitor.type === "snmp") { if (this.monitor.type === "snmp") {
this.monitor.timeout = 1; this.monitor.timeout = 1;
} else { } else {
this.monitor.timeout = 48; this.monitor.timeout = 48; // Default timeout for other monitor types
} }
// Set default SNMP version // Set default SNMP version