ric/uptime-kuma
1
0
Fork 0
mirror of https://github.com/louislam/uptime-kuma.git synced 2024-11-23 14:54:05 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

move try/catch into main control flow and more from code review comments

Browse source
This commit is contained in:
Humberto Evans 2024-02-13 17:27:59 -08:00
parent 4cdc8f344b
commit 5a9c3ad353
3 changed files with 27 additions and 28 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

41
server/notification-providers/heii-oncall.js
View file

@ -17,19 +17,24 @@ class HeiiOnCall extends NotificationProvider {
payload["url"] = baseURL + getMonitorRelativeURL(monitorJSON.id);
}
if (!heartbeatJSON) {
// Testing or general notification like certificate expiry
payload["msg"] = msg;
return this.postNotification(notification, "alert", payload);
try {
if (!heartbeatJSON) {
// Testing or general notification like certificate expiry
payload["msg"] = msg;
return this.postNotification(notification, "alert", payload);
}
if (heartbeatJSON.status === DOWN) {
return this.postNotification(notification, "alert", payload);
}
if (heartbeatJSON.status === UP) {
return this.postNotification(notification, "resolve", payload);
}
} catch (error) {
this.throwGeneralAxiosError(error);
}
if (heartbeatJSON.status === DOWN) {
return this.postNotification(notification, "alert", payload);
}
if (heartbeatJSON.status === UP) {
return this.postNotification(notification, "resolve", payload);
}
}
/**
@ -49,15 +54,11 @@ class HeiiOnCall extends NotificationProvider {
};
// Post to Heii On-Call Trigger https://heiioncall.com/docs#manual-triggers
try {
await axios.post(
`https://heiioncall.com/triggers/${notification.heiiOnCallTriggerId}/${action}`,
payload,
config
);
} catch (error) {
this.throwGeneralAxiosError(error);
}
await axios.post(
`https://heiioncall.com/triggers/${notification.heiiOnCallTriggerId}/${action}`,
payload,
config
);
return "Sent Successfully";
}

10
src/components/notifications/HeiiOnCall.vue
View file

@ -9,7 +9,7 @@
></HiddenInput>
</div>
<div class="mb-3">
<label for="heiioncall-trigger-id" class="form-label">{{ $t("Trigger ID") }}<span
<label for="heiioncall-trigger-id" class="form-label">Trigger ID<span
style="color: red;"
><sup>*</sup></span></label>
<HiddenInput
@ -17,11 +17,9 @@
autocomplete="false"
></HiddenInput>
</div>
<div class="form-text">
<i18n-t tag="p" keypath="wayToGetHeiiOnCallDetails" style="margin-top: 8px;">
<a href="https://heiioncall.com/docs" target="_blank">{{ $t("documentationOf", ["Heii On-Call"]) }}</a>
</i18n-t>
</div>
<i18n-t tag="p" keypath="wayToGetHeiiOnCallDetails" class="form-text mt-3">
<a href="https://heiioncall.com/docs" target="_blank">{{ $t("documentationOf", ["Heii On-Call"]) }}</a>
</i18n-t>
</template>
<script>

4
src/lang/en.json
View file

@ -884,6 +884,6 @@
"GrafanaOncallUrl": "Grafana Oncall URL",
"Browser Screenshot": "Browser Screenshot",
"What is a Remote Browser?": "What is a Remote Browser?",
"Trigger ID": "Trigger ID",
"wayToGetHeiiOnCallDetails": "How to get the Tigger ID and API Keys is explained in the {documentation}"
"wayToGetHeiiOnCallDetails": "How to get the Tigger ID and API Keys is explained in the {0}",
"documentationOf": "{0} Documentation"
}