ric/uptime-kuma
1
0
Fork 0
mirror of https://github.com/louislam/uptime-kuma.git synced 2024-12-18 02:47:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fixed octopush legacy doesn't return error code

Browse source 
The octopush legacy API does not return a HTTP error code and instead
always returns a HTTP 200. This means that no error it thrown even if
something like the parameters are incorrect.
Instead the error code is given in the json response data.
Therefore we must look at the response data and check for the presence
of the "error_code" key in the response data.

Signed-off-by: Matthew Nickson <mnickson@sidingsmedia.com>
This commit is contained in:
Matthew Nickson 2022-10-01 15:42:34 +01:00
parent 2e54dee817
commit 63e408f4f2
No known key found for this signature in database
GPG key ID: BF229DCFD4748E05
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
server/notification-providers/octopush.js
View file

@ -49,7 +49,13 @@ class Octopush extends NotificationProvider {
},
params: data
};
await axios.post("https://www.octopush-dm.com/api/sms/json", {}, config);
// V1 API returns 200 even on error so we must check
// response data
let response = await axios.post("https://www.octopush-dm.com/api/sms/json", {}, config);
if ("error_code" in response.data) {
this.throwGeneralAxiosError(`Octopush error ${JSON.stringify(response.data)}`);
}
} else {
throw new Error("Unknown Octopush version!");
}