ric/uptime-kuma
1
0
Fork 0
mirror of https://github.com/louislam/uptime-kuma.git synced 2024-11-27 16:54:04 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Feature - Google Analytics - Removed regex to validate a Google Analytics tag.

Browse source
This commit is contained in:
c 2023-01-31 13:18:02 +00:00
parent 3afe8013ca
commit 913bb611d5
2 changed files with 1 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
server/modules/google-analytics.js
View file

@ -1,15 +1,3 @@
/**
* Returns true if the tag conforms to the format of 1-2 Letters followed by a dash and 8 numbers.
* This should take care of the following property tag formats:
* UA-########, G-########, AW-########, DC-########
* @param {String} tagInput Google UA/G/AW/DC Property ID
* @returns {boolean}
*/
function isValidTag(tagInput) {
const re = /^\w{1,2}-\d{8}$/g;
return tagInput.match(re) != null;
}
/**
* Returns a string that represents the javascript that is required to insert the Google Analytics scripts
* into a webpage.
@ -23,5 +11,4 @@ function getGoogleAnalyticsScript(tagId) {
module.exports = {
getGoogleAnalyticsScript,
isValidTag,
};

2
server/socket-handlers/status-page-socket-handler.js
View file

@ -164,7 +164,7 @@ module.exports.statusPageSocketHandler = (socket) => {
statusPage.custom_css = config.customCSS;
statusPage.show_powered_by = config.showPoweredBy;
statusPage.modified_date = R.isoDateTime();
statusPage.google_analytics_tag_id = googleAnalytics.isValidTag(config.googleAnalyticsId) ? config.googleAnalyticsId : "";
statusPage.google_analytics_tag_id = config.googleAnalyticsId;
await R.store(statusPage);