ric/uptime-kuma
1
0
Fork 0
mirror of https://github.com/louislam/uptime-kuma.git synced 2024-10-30 03:00:40 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

fix: add serverside check against endless loops

Browse source
This commit is contained in:
Peace 2023-02-01 20:16:56 +01:00
parent 66573934f6
commit 9286dcb6ce
No known key found for this signature in database
GPG key ID: 0EF6B46E172B739F
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
server/server.js
View file

@ -674,6 +674,14 @@ let needSetup = false;
throw new Error("Permission denied."); throw new Error("Permission denied.");
} }
// Check if Parent is Decendant (would cause endless loop)
if (monitor.parent !== null) {
const childIDs = await Monitor.getAllChildrenIDs(monitor.id);
if (childIDs.includes(monitor.parent)) {
throw new Error("Invalid Monitor Group");
}
}
// Reset Prometheus labels // Reset Prometheus labels
server.monitorList[monitor.id]?.prometheus()?.remove(); server.monitorList[monitor.id]?.prometheus()?.remove();