ric/uptime-kuma
1
0
Fork 0
mirror of https://github.com/louislam/uptime-kuma.git synced 2024-11-23 14:54:05 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Apply suggestions from code review

Browse source 
Co-authored-by: Frank Elsinga <frank@elsinga.de>
This commit is contained in:
Matt Visnovsky 2024-06-12 14:25:25 -06:00 committed by GitHub
parent 5dc4bb64d5
commit b5a73e5ad7
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 21 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
server/model/monitor.js
View file

@ -602,9 +602,12 @@ class Monitor extends BeanModel {
const { status, response } = await evaluateJsonQuery(data, this.jsonPath, this.jsonPathOperator, this.expectedValue); const { status, response } = await evaluateJsonQuery(data, this.jsonPath, this.jsonPathOperator, this.expectedValue);
bean.status = status ? UP : DOWN; if (status) {
bean.msg = `JSON query ${status ? "passes" : "does not pass"} `; bean.status = UP;
bean.msg += `comparison: ${response} ${this.jsonPathOperator} ${this.expectedValue}.`; bean.msg = `JSON query passes (comparing ${response} ${this.jsonPathOperator} ${this.expectedValue})`
} else {
throw new Error(`JSON query does not pass (comparing ${response} ${this.jsonPathOperator} ${this.expectedValue})`);
}
} }

29
server/monitor-types/snmp.js
View file

@ -9,17 +9,15 @@ class SNMPMonitorType extends MonitorType {
* @inheritdoc * @inheritdoc
*/ */
async check(monitor, heartbeat, _server) { async check(monitor, heartbeat, _server) {
const options = {
port: monitor.port || "161",
retries: monitor.maxretries,
timeout: monitor.timeout * 1000,
version: snmp.Version[monitor.snmpVersion],
};
let session; let session;
try { try {
session = snmp.createSession(monitor.hostname, monitor.radiusPassword, options); const sessionOptions = {
port: monitor.port || "161",
retries: monitor.maxretries,
timeout: monitor.timeout * 1000,
version: snmp.Version[monitor.snmpVersion],
};
session = snmp.createSession(monitor.hostname, monitor.radiusPassword, sessionOptions);
// Handle errors during session creation // Handle errors during session creation
session.on("error", (error) => { session.on("error", (error) => {
@ -46,13 +44,14 @@ class SNMPMonitorType extends MonitorType {
const { status, response } = await evaluateJsonQuery(value, monitor.jsonPath, monitor.jsonPathOperator, monitor.expectedValue); const { status, response } = await evaluateJsonQuery(value, monitor.jsonPath, monitor.jsonPathOperator, monitor.expectedValue);
heartbeat.status = status ? UP : DOWN; if (status) {
heartbeat.msg = `SNMP value ${status ? "passes" : "does not pass"} `; bean.status = UP;
heartbeat.msg += `comparison: ${response} ${monitor.jsonPathOperator} ${monitor.expectedValue}.`; bean.msg = `JSON query passes (comparing ${response} ${this.jsonPathOperator} ${this.expectedValue})`
} else {
throw new Error(`JSON query does not pass (comparing ${response} ${this.jsonPathOperator} ${this.expectedValue})`);
}
} catch (err) { } catch (err) {
heartbeat.status = DOWN; throw err;
heartbeat.msg = `Error: ${err.message}`;
} finally { } finally {
if (session) { if (session) {
session.close(); session.close();

2
src/pages/EditMonitor.vue
View file

@ -1354,7 +1354,7 @@ message HealthCheckResponse {
// Set default SNMP version // Set default SNMP version
if (!this.monitor.snmpVersion) { if (!this.monitor.snmpVersion) {
this.monitor.snmpVersion = "1"; this.monitor.snmpVersion = "2c";
} }
// Set default jsonPath // Set default jsonPath