ric/uptime-kuma
1
0
Fork 0
mirror of https://github.com/louislam/uptime-kuma.git synced 2025-01-31 08:46:16 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fix #1318, basic auth is completely disabled if the auth is disabled

Browse source
This commit is contained in:
Louis Lam 2022-03-24 18:02:34 +08:00
parent 775d1696fa
commit d32ba7cadd
1 changed files with 31 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

52
server/auth.js
View file

@ -31,31 +31,41 @@ exports.login = async function (username, password) {
}; };
function myAuthorizer(username, password, callback) { function myAuthorizer(username, password, callback) {
setting("disableAuth").then((result) => { // Login Rate Limit
if (result) { loginRateLimiter.pass(null, 0).then((pass) => {
callback(null, true); if (pass) {
} else { exports.login(username, password).then((user) => {
// Login Rate Limit callback(null, user != null);
loginRateLimiter.pass(null, 0).then((pass) => {
if (pass) {
exports.login(username, password).then((user) => {
callback(null, user != null);
if (user == null) { if (user == null) {
loginRateLimiter.removeTokens(1); loginRateLimiter.removeTokens(1);
}
});
} else {
callback(null, false);
} }
}); });
} else {
callback(null, false);
} }
}); });
} }
exports.basicAuth = basicAuth({ /**
authorizer: myAuthorizer, * If disabled auth, it does not call `next`.
authorizeAsync: true, */
challenge: true, exports.checkBasicAuth = async (req, res, next) => {
});
};
exports.basicAuth = async function (req, res, next) {
const middleware = basicAuth({
authorizer: myAuthorizer,
authorizeAsync: true,
challenge: true,
});
const disabledAuth = await setting("disableAuth");
if (!disabledAuth) {
middleware(req, res, next);
} else {
next();
}
};