Commit graph

5840 commits

Author SHA1 Message Date
Matt Visnovsky
c4759948ec Fix ES Lint 2024-05-08 11:00:18 -06:00
Matt Visnovsky
1c4740748c Re-use monitor.radiusPassword for community string 2024-05-08 11:00:10 -06:00
Matt Visnovsky
da8f0d1c31
Apply suggestions from code review
Co-authored-by: Frank Elsinga <frank@elsinga.de>
2024-05-08 10:06:20 -06:00
Matt Visnovsky
8b4b27f359 Final cleanup of changes to EditMonitor.vue
Reverts unintentional changes committed in: d92003e172
2024-05-07 10:05:36 -06:00
Matt Visnovsky
2015142b00 Maybe don't helptext all the things...
Addresses https://github.com/louislam/uptime-kuma/pull/4717#discussion_r1589866321
2024-05-07 09:23:23 -06:00
Matt Visnovsky
e5fb726160 Missed changes leftover from removal of getKey() 2024-05-07 09:16:23 -06:00
Matt Visnovsky
2b5d100cd3 Ensure SNMP session is closed properly
Addresses https://github.com/louislam/uptime-kuma/pull/4717#discussion_r1589858252

Co-Authored-By: Frank Elsinga <frank.elsinga@tum.de>
2024-05-06 15:56:41 -06:00
Matt Visnovsky
f4842ead68 Translation key for OID 2024-05-06 15:38:14 -06:00
Matt Visnovsky
56e7fa8bd5 Helptext ALL THE THINGS 2024-05-06 14:33:48 -06:00
Matt Visnovsky
19f21a9a39 SNMP OID helptext 2024-05-06 14:19:33 -06:00
Matt Visnovsky
4ef66b3760 SNMP version helptext 2024-05-06 14:17:46 -06:00
Matt Visnovsky
e9b52eb0e7 Separate error cases for SNMP varbind returns 2024-05-06 14:06:40 -06:00
Matt Visnovsky
c68b1c6274 Remove unnecessary func getKey 2024-05-06 12:05:12 -06:00
Matt Visnovsky
6037912085 Consistent placeholder text
Co-Authored-By: Frank Elsinga <frank.elsinga@tum.de>
2024-05-06 09:58:39 -06:00
Matt Visnovsky
433e317eee Simplify error catch
Co-Authored-By: Frank Elsinga <frank.elsinga@tum.de>
2024-05-06 09:57:13 -06:00
Matt Visnovsky
1fe1bb5864 Given that above throws, the else case is not nessesary
Co-Authored-By: Frank Elsinga <frank.elsinga@tum.de>
2024-05-06 09:53:14 -06:00
Matt Visnovsky
997791bc78 Default: invalid condition error
Co-Authored-By: Frank Elsinga <frank.elsinga@tum.de>
2024-05-06 09:51:37 -06:00
Matt Visnovsky
0384b34007 Remove unnecessary func getKey
Addresses:
- https://github.com/louislam/uptime-kuma/pull/4717#discussion_r1589856311
- https://github.com/louislam/uptime-kuma/pull/4717#discussion_r1589862733
2024-05-06 09:49:36 -06:00
Matt Visnovsky
86b997c664 Limit to <= SNMPv2c for now 2024-05-06 09:47:51 -06:00
Matt Visnovsky
0280b2ad3f A comment about varbinds[0] for clarification
Addresses https://github.com/louislam/uptime-kuma/pull/4717#discussion_r1589855126
2024-05-06 09:21:49 -06:00
Matt Visnovsky
4386d0afad Apply suggestions from code review
Addresses:
-https://github.com/louislam/uptime-kuma/pull/4717#discussion_r1589805237
-https://github.com/louislam/uptime-kuma/pull/4717#discussion_r1589806199
-https://github.com/louislam/uptime-kuma/pull/4717#discussion_r1589853470
-https://github.com/louislam/uptime-kuma/pull/4717#discussion_r1589854032
2024-05-05 15:47:43 -06:00
Matt Visnovsky
9053b48030
Merge branch 'louislam:master' into snmp-monitor 2024-05-03 16:13:40 -06:00
Matt Visnovsky
407f7291b0 New dependency for net-snmp 2024-05-03 11:58:03 -06:00
Matt Visnovsky
09fd816aae Updated code comments 2024-05-03 11:52:02 -06:00
Matt Visnovsky
c87ac2f043 Move getKey() to util.ts 2024-05-03 11:39:14 -06:00
Matt Visnovsky
8e56a81ef1 Refactor how strings/numerics are parsed
Fixes issue `toString() radix argument must be between 2 and 36` due to `.toString("ascii")` conversion. This issue was introduced in 704ffd3f4b.
2024-05-02 15:11:03 -06:00
Matt Visnovsky
f059d54349 Use frontend timeout
Addresses https://github.com/louislam/uptime-kuma/pull/4717#discussion_r1585616669
2024-05-02 15:07:22 -06:00
Matt Visnovsky
d83c2b90c9 Revert unintentional changes to EditMonitor.vue
Reverts unintentional changes committed in: d92003e172
2024-05-02 09:50:09 -06:00
Frank Elsinga
dbbc79a05a
Fixed a typo introduced in #3836 (#4729)
Co-authored-by: Nelson Chan <3271800+chakflying@users.noreply.github.com>
2024-05-02 12:11:49 +08:00
Matt Visnovsky
4699a1ccd8 ES Lint Compliant
Also changed line endings from 'LF' to 'CRLF'
2024-05-01 10:29:13 -06:00
Matt Visnovsky
ba84f01444 Delete .EditMonitor.vue.swp
Co-Authored-By: Frank Elsinga <frank.elsinga@tum.de>
2024-05-01 09:15:35 -06:00
Matt Visnovsky
9ba0f68a86 Remove supurfluous log.debug
Co-Authored-By: Frank Elsinga <frank.elsinga@tum.de>
2024-04-30 18:19:18 -06:00
Matt Visnovsky
97a9094d7c ES Lint Compliant 2024-04-30 18:14:58 -06:00
Matt Visnovsky
e944492da8 Corrected down function
b4bd003626 (r1585590243)
2024-04-30 18:06:03 -06:00
Matt Visnovsky
7459654e11 ES Lint Compliant 2024-04-30 18:04:59 -06:00
Matt Visnovsky
ba47aca51f
Apply suggestions from code review
Co-authored-by: Frank Elsinga <frank@elsinga.de>
2024-04-30 17:54:29 -06:00
Frank Elsinga
b4bd003626
Merge branch 'master' into snmp-monitor 2024-05-01 00:01:03 +02:00
Matt Visnovsky
704ffd3f4b Finalized SNMP monitor 2024-04-30 15:18:25 -06:00
Matt Visnovsky
9848ce49f3 Minor frontend styling 2024-04-30 15:16:45 -06:00
Matt Visnovsky
4593afbdbb Frontend input validation 2024-04-30 15:15:37 -06:00
Matt Visnovsky
9d28fcff1a Update bean model backend
Updates appropriate values async when editing the SNMP monitor
2024-04-30 15:13:16 -06:00
Matt Visnovsky
9c8024c7fa Update db migration: down function
knex requires down function
2024-04-30 15:11:21 -06:00
Matt Visnovsky
138075a2af Update db migration: allow nulls
DB must allow nulls otherwise this will break other monitors.
2024-04-30 15:10:57 -06:00
Rakovskij Stanislav
9f2cf28a76
Making docker usage with localhost and external ip more clear (#3836)
Co-authored-by: Frank Elsinga <frank@elsinga.de>
2024-04-30 22:53:27 +02:00
Nelson Chan
59f10d542b
Fix: Show API Keys disabled msg. when disabled Auth (#4723)
Co-authored-by: Frank Elsinga <frank@elsinga.de>
2024-04-30 22:11:09 +02:00
Ezhil Shanmugham
988ba79679
feat: keephq notification provider (#4722) 2024-04-30 16:17:34 +02:00
Matt Visnovsky
99dc4cfb46 Wrong variable used
Thanks for pointing it out @CommanderStorm!
2024-04-29 22:24:51 -06:00
Matt Visnovsky
4a882be6ba Further SNMP monitor development
Further testing of SNMP feat, however I'm running into the issue `Error in SNMP check: RequestTimedOutError: Request timed out` when the check function is called. I am unsure as to why since my local SNMP script works great with very similar code.
2024-04-29 15:59:59 -06:00
Matt Visnovsky
ff5890a11f Updated a comment 2024-04-29 15:59:21 -06:00
Matt Visnovsky
a3cdd69995 Use net-snmp instead of snmp-native
net-snmp over snmp-native is:
-more robust
-more popular
-better documented
-supports v3
2024-04-29 13:58:43 -06:00