Co-authored-by: Frank Elsinga <frank@elsinga.de>
Closes: #4391
Squashed commit of the following:
commit 828d2a73d4
Merge: 10f771cfdd758903
Author: Frank Elsinga <frank@elsinga.de>
Date: Fri Sep 13 22:51:25 2024 +0800
Merge branch 'master' into deprecations
commit 10f771cfc6
Author: Frank Elsinga <frank@elsinga.de>
Date: Thu Jan 18 22:36:12 2024 +0100
formatting fixes
commit d737b19e2f
Author: Frank Elsinga <frank@elsinga.de>
Date: Thu Jan 18 21:27:30 2024 +0100
migrated all settings to use the `Settings` class
commit c5e26e993e
Author: Frank Elsinga <frank@elsinga.de>
Date: Thu Jan 18 21:04:44 2024 +0100
removed the deprecated logging functionality
* fix(server/model/monitor): duplicate `Settings.set` for `tlsExpiryNotifyDays`
* fix(eslint): minor linter complaints & a typo
- I unified where in file the name of `NotificationProvider.name` is placed
- I made sure that all the providers adhere to the signature of `NotificationProvider.send()`
- I made sure that all the providers use `okMsg` if returning success messages directly from the function.
Here a discussion should be had:
Should this be refactored into a constant of `NotificationProvider`? I could imagine that `NotificationProvider.SENDING_SUCCESSFULL` could be a suitable alternative.
- I made sure all providers have the URL they `POST`/`GET` to be extraced into a variable.
=> refactored this way due to Nelsons suggestion
